Discussion:
XBOX/i386 and xlint removal
(too old to reply)
Konstantin Belousov
2017-11-09 13:52:21 UTC
Permalink
Hello,
I created two reviews to axe two features which I personally find of
little use in modern FreeBSD.

https://reviews.freebsd.org/D13015 xlint
https://reviews.freebsd.org/D13016 XBOX/i386

Reviews contain the explanations. For xlint it is just an overdue, IMO.
While for XBOX I do not have much opposition against supporting the
obsoleted platforms, but the way the port was done pollutes the sources
with too much #ifdefs. Since people often do not want to care about i386
together with amd64, additional hurdle only makes the things worse.

Feel free to add yourself as reviewer. I intend to commit the patches
in a week, unless strong objections expressed by the time.
Warner Losh
2017-11-09 14:56:24 UTC
Permalink
This post might be inappropriate. Click to display it.
Konstantin Belousov
2017-11-21 16:36:00 UTC
Permalink
Post by Konstantin Belousov
Hello,
I created two reviews to axe two features which I personally find of
little use in modern FreeBSD.
...

I put the follow up to remove the lint support from the headers.
Feel free to review and comment, after adding yourself as reviewer.

https://reviews.freebsd.org/D13156

Only include/ include/sys and x86 are handled.
Guido Falsi
2017-12-12 11:04:49 UTC
Permalink
Post by Konstantin Belousov
Hello,
I created two reviews to axe two features which I personally find of
little use in modern FreeBSD.
https://reviews.freebsd.org/D13015 xlint
Hi,

I just discovered that this change brakes building a pre change system
(using nanobsd scripts for example) from head.

The sources before this change expect lint to be present and actually use it

I have worked around this by commenting out xlint from the build in the
11.1 sources, since I don't need it.

Maybe simply defining LINT="" would work too. (I'll test this approach
later)

I have no need for xlint and have no objection to it's removal, but
loosing the ability to build older source trees from head looks wrong.

Don't know if modifying older branches to cope with the lint command not
being present is a viable option.
--
Guido Falsi <***@FreeBSD.org>
Loading...