HEAD amd64 seems unhappy

Discussion:

(too old to reply)

Josh Paetzel

2018-02-04 02:38:22 UTC

--- all_subdir_lib/libngatm ---
/usr/src/sys/contrib/ngatm/netnatm/api/cc_port.c:71:28: error: result of comparison 'u_int' (aka 'unsigned int') > 4294967295 is always fal
se [-Werror,-Wtautological-type-limit-compare]
if (portno == 0 || portno > 0xffffffff)
~~~~~~ ^ ~~~~~~~~~~
1 error generated.
*** [cc_port.o] Error code 1

This code hasn't changed in ages so I can only assume it's clang or such.

--
Thanks,

Josh Paetzel

David Wolfskill

2018-02-04 13:15:46 UTC

Permalink

Post by Josh Paetzel
--- all_subdir_lib/libngatm ---
/usr/src/sys/contrib/ngatm/netnatm/api/cc_port.c:71:28: error: result of comparison 'u_int' (aka 'unsigned int') > 4294967295 is always fal
se [-Werror,-Wtautological-type-limit-compare]
if (portno == 0 || portno > 0xffffffff)
~~~~~~ ^ ~~~~~~~~~~
1 error generated.
*** [cc_port.o] Error code 1
This code hasn't changed in ages so I can only assume it's clang or such.
....

My update of head/amd64 from r328830 to r328838 was rather quick
and quite painless this morning (00:05:15 elapsed time... on my
laptop; build machine was < 00:05:00, as I didn't need to re-authenticate
to sudo for the shutdown).

So: I didn't see the issue.

Peace,
david

--
David H. Wolfskill ***@catwhisker.org
The circus around that memo helps confirm that Mr. Trump is unfit for office.

See http://www.catwhisker.org/~david/publickey.gpg for my public key.

Dimitry Andric

2018-02-04 10:24:38 UTC

Permalink

This is because of r328816, which requires you to update your toolchain
to at least r328381. E.g. please run either "make buildworld" or "make
kernel-toolchain" before building your kernel.

-Dimitry

Stefan Hagen

2018-02-04 19:36:15 UTC

Permalink

Post by Dimitry Andric

This is because of r328816, which requires you to update your toolchain
to at least r328381. E.g. please run either "make buildworld" or "make
kernel-toolchain" before building your kernel.

I get the same error. It actually comes up at "make buildworld".
Running "make kernel-toolchain" before did not help. I'm on r328860.

Best Regards,
Stefan

Michael Tuexen

2018-02-04 19:59:14 UTC

Permalink

Post by Dimitry Andric

This is because of r328816, which requires you to update your toolchain
to at least r328381. E.g. please run either "make buildworld" or "make
kernel-toolchain" before building your kernel.

I get this error when doing a buildworld... Using r328861.

Best regards
Michael

Post by Dimitry Andric
-Dimitry

Dimitry Andric

2018-02-04 20:40:19 UTC

Permalink

Post by Michael Tuexen

Post by Dimitry Andric

This is because of r328816, which requires you to update your toolchain
to at least r328381. E.g. please run either "make buildworld" or "make
kernel-toolchain" before building your kernel.

I get this error when doing a buildworld... Using r328861.

This should now be fixed by r328863. The MK_SYSTEM_COMPILER logic did
not build a cross-tools toolchain, so you were still getting warnings
from the (old) compiler in your base system.

-Dimitry

Michael Tuexen

2018-02-04 21:54:41 UTC

Permalink

Post by Dimitry Andric

Post by Michael Tuexen

Post by Dimitry Andric

This is because of r328816, which requires you to update your toolchain
to at least r328381. E.g. please run either "make buildworld" or "make
kernel-toolchain" before building your kernel.

I get this error when doing a buildworld... Using r328861.

This should now be fixed by r328863. The MK_SYSTEM_COMPILER logic did
not build a cross-tools toolchain, so you were still getting warnings
from the (old) compiler in your base system.

I can confirm that it works now.

Thanks for the quick fix!

Best regards
Michael

Post by Dimitry Andric
-Dimitry