Discussion:
Proper way to remove never used ioctls
(too old to reply)
Vladimir Kondratyev
2018-06-02 13:33:41 UTC
Permalink
Hi,

Our sys/mouse.h header has a definition of MOUSE_GETVARS and
MOUSE_SETVARS ioctls which are not documented and only stubbed in a few
drivers: mse(4), psm(4) and syscon's sysmouse(4). The only exception is
MOUSE_GETVARS implemented in psm(4)

Given the fact that they were introduced 20 years ago, implementation
was never completed and googling on them shows no traces of usage in
indexed universe, is it acceptable to just drop both defines and
implementation w.o. leaving any COMPAT_FREEBSD shims?
--
WBR
Vladimir Kondratyev
Warner Losh
2018-06-02 15:03:04 UTC
Permalink
Hi,
Our sys/mouse.h header has a definition of MOUSE_GETVARS and MOUSE_SETVARS
ioctls which are not documented and only stubbed in a few drivers: mse(4),
psm(4) and syscon's sysmouse(4). The only exception is MOUSE_GETVARS
implemented in psm(4)
Given the fact that they were introduced 20 years ago, implementation was
never completed and googling on them shows no traces of usage in indexed
universe, is it acceptable to just drop both defines and implementation
w.o. leaving any COMPAT_FREEBSD shims?
I'd prepare a patch just removing them. I'd then send that patch to the
ports mgr team and request a exp-run. Details for that can be found in
https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/ports.html

Once that's done, submit a Phabricator review and send me email. I'll make
sure it gets pushed in if there's no objections.

Warner
Allan Jude
2018-06-02 17:36:49 UTC
Permalink
Post by Warner Losh
Hi,
Our sys/mouse.h header has a definition of MOUSE_GETVARS and MOUSE_SETVARS
ioctls which are not documented and only stubbed in a few drivers: mse(4),
psm(4) and syscon's sysmouse(4). The only exception is MOUSE_GETVARS
implemented in psm(4)
Given the fact that they were introduced 20 years ago, implementation was
never completed and googling on them shows no traces of usage in indexed
universe, is it acceptable to just drop both defines and implementation
w.o. leaving any COMPAT_FREEBSD shims?
I'd prepare a patch just removing them. I'd then send that patch to the
ports mgr team and request a exp-run. Details for that can be found in
https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/ports.html
Once that's done, submit a Phabricator review and send me email. I'll make
sure it gets pushed in if there's no objections.
Warner
_______________________________________________
https://lists.freebsd.org/mailman/listinfo/freebsd-current
This indeed seems to be the correct approach. The exp-run will compile
the entire ports tree against the patched base system, and identify any
3rd party software that fails to compile because of the change.
--
Allan Jude
Vladimir Kondratyev
2018-06-02 18:30:09 UTC
Permalink
Post by Allan Jude
On Sat, Jun 2, 2018 at 7:33 AM, Vladimir Kondratyev
Post by Vladimir Kondratyev
Hi,
Our sys/mouse.h header has a definition of MOUSE_GETVARS and
MOUSE_SETVARS
ioctls which are not documented and only stubbed in a few drivers: mse(4),
psm(4) and syscon's sysmouse(4). The only exception is MOUSE_GETVARS
implemented in psm(4)
Given the fact that they were introduced 20 years ago, implementation was
never completed and googling on them shows no traces of usage in indexed
universe, is it acceptable to just drop both defines and
implementation
w.o. leaving any COMPAT_FREEBSD shims?
I'd prepare a patch just removing them. I'd then send that patch to the
ports mgr team and request a exp-run. Details for that can be found in
https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/ports.html
Once that's done, submit a Phabricator review and send me email. I'll make
sure it gets pushed in if there's no objections.
Warner
This indeed seems to be the correct approach. The exp-run will compile
the entire ports tree against the patched base system, and identify any
3rd party software that fails to compile because of the change.
Thank you, Allan and Warner! I'll follow yours advice.
--
WBR
Vladimir Kondratyev
blubee blubeeme
2018-06-02 22:52:38 UTC
Permalink
Post by Warner Losh
Post by Allan Jude
On Sat, Jun 2, 2018 at 7:33 AM, Vladimir Kondratyev
Hi,
Our sys/mouse.h header has a definition of MOUSE_GETVARS and MOUSE_SETVARS
ioctls which are not documented and only stubbed in a few drivers: mse(4),
psm(4) and syscon's sysmouse(4). The only exception is MOUSE_GETVARS
implemented in psm(4)
Given the fact that they were introduced 20 years ago, implementation was
never completed and googling on them shows no traces of usage in indexed
universe, is it acceptable to just drop both defines and
implementation
w.o. leaving any COMPAT_FREEBSD shims?
I'd prepare a patch just removing them. I'd then send that patch to the
ports mgr team and request a exp-run. Details for that can be found in
https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/ports.html
Post by Allan Jude
Once that's done, submit a Phabricator review and send me email. I'll make
sure it gets pushed in if there's no objections.
Warner
This indeed seems to be the correct approach. The exp-run will compile
the entire ports tree against the patched base system, and identify any
3rd party software that fails to compile because of the change.
Thank you, Allan and Warner! I'll follow yours advice.
--
WBR
Vladimir Kondratyev
_______________________________________________
https://lists.freebsd.org/mailman/listinfo/freebsd-current
This was great information.
Loading...