Fatal trap 12 booting FreeBSD-CURRENT via isboot kernel module.

Discussion:

(too old to reply)

Maurizio Vairani

2018-01-29 13:05:22 UTC

I am running
# uname
-a

FreeBSD 12.0-CURRENT FreeBSD 12.0-CURRENT #0 r328383: Thu Jan 25 04:48:52
UTC 2018 ***@releng3.nyi.freebsd.org:/usr/obj/usr/src/amd64.amd64/sys/GENERIC
amd64

After compiling the kernel module as discussed in this thread :
https://lists.freebsd.org/pipermail/freebsd-current/2018-January/068272.html

I can boot FreeBSD via iSCSI using iPXE. But when the isboot, the iSCSI
boot driver version 0.2.13, starts I receive a panic:
https://mega.nz/#!tkVwBBKA!PUj14-Za6KCNaoo9hxuXORRLQoWkb4LMvTdUA1BorD4

Any idea?
--
Thanks,
Maurizio

John Nielsen

2018-01-29 17:38:04 UTC

Permalink

[ resending from correct email address ]

Post by Maurizio Vairani
I am running
# uname
-a
FreeBSD 12.0-CURRENT FreeBSD 12.0-CURRENT #0 r328383: Thu Jan 25 04:48:52
amd64
https://lists.freebsd.org/pipermail/freebsd-current/2018-January/068272.html
I can boot FreeBSD via iSCSI using iPXE. But when the isboot, the iSCSI
https://mega.nz/#!tkVwBBKA!PUj14-Za6KCNaoo9hxuXORRLQoWkb4LMvTdUA1BorD4
Any idea?

Bummer!

Aoyama-san-

Are you still maintaining isboot? Can you help debug this issue on FreeBSD 12-CURRENT?

Once we get it working I will update the port with whatever is needed and send you the patches in case you'd like to cut a new release.

Thank you!

Maurizio Vairani

2018-02-04 09:50:28 UTC

Permalink

Post by John Nielsen
[ resending from correct email address ]
I am running
# uname
-a
FreeBSD 12.0-CURRENT FreeBSD 12.0-CURRENT #0 r328383: Thu Jan 25 04:48:52
amd64/sys/GENERIC
amd64
https://lists.freebsd.org/pipermail/freebsd-current/
2018-January/068272.html
I can boot FreeBSD via iSCSI using iPXE. But when the isboot, the iSCSI
https://mega.nz/#!tkVwBBKA!PUj14-Za6KCNaoo9hxuXORRLQoWkb4LMvTdUA1BorD4
Any idea?
Bummer!
Aoyama-san-
Are you still maintaining isboot? Can you help debug this issue on FreeBSD 12-CURRENT?
Once we get it working I will update the port with whatever is needed and
send you the patches in case you'd like to cut a new release.
Thank you!

I have solved the issue changing the function isboot_ifup() in the source
file isboot.c.

static int
isboot_ifup(struct ifnet *ifp)
{
struct socket *so;
struct ifreq ifr;
struct thread *td;
int error;

td = curthread;
error = socreate(AF_INET, &so, SOCK_DGRAM, 0, td->td_ucred, td);
if (error) {
printf("%s: socreate, error=%d\n", __func__, error);
return (error);
}

/* boot NIC */
memset(&ifr, 0, sizeof(ifr));
strlcpy(ifr.ifr_name, ifp->if_xname, sizeof(ifr.ifr_name));

/* set IFF_UP */
error = ifioctl(so, SIOCGIFFLAGS, (caddr_t)&ifr, td);
if (error) {
printf("%s: ifioctl SIOCGIFFLAGS, error=%d\n", __func__, error);
return (error);
}

ifr.ifr_flags |= IFF_UP;
error = ifioctl(so, SIOCSIFFLAGS, (caddr_t)&ifr, td);
if (error) {
printf("%s, ifioctl SIOCSIFFLAGS, error=%d\n", __func__, error);
return (error);
}
soclose(so);
return (0);
}

I have added a socket in the ifioctl() call as in the
/usr/src/sys/nfs/bootp_subr.c source.
Please let me know if you prefer a patch.
--
Regards,
Maurizio

Andriy Gapon

2018-02-04 13:40:18 UTC

Permalink

Post by Maurizio Vairani
I have added a socket in the ifioctl() call as in the
/usr/src/sys/nfs/bootp_subr.c source.
Please let me know if you prefer a patch.

A patch here https://reviews.freebsd.org/ would be the best.

--
Andriy Gapon

Maurizio Vairani

2018-03-28 07:56:01 UTC

Permalink

Post by Andriy Gapon

Post by Maurizio Vairani
I have added a socket in the ifioctl() call as in the
/usr/src/sys/nfs/bootp_subr.c source.
Please let me know if you prefer a patch.

A patch here https://reviews.freebsd.org/ would be the best.
--
Andriy Gapon

Hi,
I have uploaded a patch here:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=226982
--
Maurizio

John Nielsen

2018-02-05 20:17:51 UTC

Permalink

Post by John Nielsen
[ resending from correct email address ]

Bummer!
Aoyama-san-
Are you still maintaining isboot? Can you help debug this issue on FreeBSD 12-CURRENT?
Once we get it working I will update the port with whatever is needed and send you the patches in case you'd like to cut a new release.
Thank you!
I have solved the issue changing the function isboot_ifup() in the source file isboot.c.

Nice work, thank you! I'll put the below together with the necessary changes to iscsi.c and update the port. If you could re-install from the port at that point as a further test/sanity check that would be great.

Post by John Nielsen
static int
isboot_ifup(struct ifnet *ifp)
{
struct socket *so;
struct ifreq ifr;
struct thread *td;
int error;
td = curthread;
error = socreate(AF_INET, &so, SOCK_DGRAM, 0, td->td_ucred, td);
if (error) {
printf("%s: socreate, error=%d\n", __func__, error);
return (error);
}
/* boot NIC */
memset(&ifr, 0, sizeof(ifr));
strlcpy(ifr.ifr_name, ifp->if_xname, sizeof(ifr.ifr_name));
/* set IFF_UP */
error = ifioctl(so, SIOCGIFFLAGS, (caddr_t)&ifr, td);
if (error) {
printf("%s: ifioctl SIOCGIFFLAGS, error=%d\n", __func__, error);
return (error);
}
ifr.ifr_flags |= IFF_UP;
error = ifioctl(so, SIOCSIFFLAGS, (caddr_t)&ifr, td);
if (error) {
printf("%s, ifioctl SIOCSIFFLAGS, error=%d\n", __func__, error);
return (error);
}
soclose(so);
return (0);
}
I have added a socket in the ifioctl() call as in the /usr/src/sys/nfs/bootp_subr.c source.
Please let me know if you prefer a patch.
--
Regards,
Maurizio

John Nielsen

2018-02-06 17:54:58 UTC

Permalink

Post by John Nielsen
[ resending from correct email address ]

Bummer!
Aoyama-san-
Are you still maintaining isboot? Can you help debug this issue on FreeBSD 12-CURRENT?
Once we get it working I will update the port with whatever is needed and send you the patches in case you'd like to cut a new release.
Thank you!
I have solved the issue changing the function isboot_ifup() in the source file isboot.c.

Here is a patch with some changes to minimize the diff. Except for the printed error messages does that look functionally equivalent?

Now the question is why is this change needed and for what values of __FreeBSD_version is it appropriate?

# diff -u isboot.c.patched1 isboot.c
--- isboot.c.patched1 2018-02-06 10:35:20.808692000 -0700
+++ isboot.c 2018-02-06 10:50:05.347663000 -0700
@@ -417,28 +417,36 @@
isboot_ifup(struct ifnet *ifp)
{
struct ifreq ifr;
+ struct socket *so;
struct thread *td;
int error;

memset(&ifr, 0, sizeof(ifr));
td = curthread;

+ error = socreate(AF_INET, &so, SOCK_DGRAM, 0, td->td_ucred, td);
+ if (error) {
+ printf("%s: socreate, error=%d\n", __func__, error);
+ return (error);
+ }
+
/* boot NIC */
strlcpy(ifr.ifr_name, ifp->if_xname, sizeof(ifr.ifr_name));

/* set IFF_UP */
- error = ifioctl(NULL, SIOCGIFFLAGS, (caddr_t)&ifr, td);
+ error = ifioctl(so, SIOCGIFFLAGS, (caddr_t)&ifr, td);
if (error) {
printf("ifioctl SIOCGIFFLAGS\n");
return (error);
}
ifr.ifr_flags |= IFF_UP;
- error = ifioctl(NULL, SIOCSIFFLAGS, (caddr_t)&ifr, td);
+ error = ifioctl(so, SIOCSIFFLAGS, (caddr_t)&ifr, td);
if (error) {
printf("ifioctl SIOCSIFFLAGS\n");
return (error);
}

+ soclose(so);
return (0);
}

John Nielsen

2018-02-06 18:33:22 UTC

Permalink

Post by John Nielsen

Post by John Nielsen
[ resending from correct email address ]

Bummer!
Aoyama-san-
Are you still maintaining isboot? Can you help debug this issue on FreeBSD 12-CURRENT?
Once we get it working I will update the port with whatever is needed and send you the patches in case you'd like to cut a new release.
Thank you!
I have solved the issue changing the function isboot_ifup() in the source file isboot.c.

Apparently sending a NULL socket pointer to ifioctl hasn't worked since this commit in 2011:
https://svnweb.freebsd.org/base?view=revision&revision=218757

So I'm going to add this patch to the port unconditionally once it works.

Unfortunately, I can't compile the port with either my patch below or your original replacement version of isboot_ifup(). :( Did you make other changes? Here's the error I'm getting:

--- isboot.o ---
isboot.c:425:53: error: incomplete definition of type 'struct thread'
error = socreate(AF_INET, &so, SOCK_DGRAM, 0, td->td_ucred, td);
~~^
/usr/src/sys/sys/systm.h:185:8: note: forward declaration of 'struct thread'
struct thread;
^
1 error generated.

Post by John Nielsen
# diff -u isboot.c.patched1 isboot.c
--- isboot.c.patched1 2018-02-06 10:35:20.808692000 -0700
+++ isboot.c 2018-02-06 10:50:05.347663000 -0700
@@ -417,28 +417,36 @@
isboot_ifup(struct ifnet *ifp)
{
struct ifreq ifr;
+ struct socket *so;
struct thread *td;
int error;
memset(&ifr, 0, sizeof(ifr));
td = curthread;
+ error = socreate(AF_INET, &so, SOCK_DGRAM, 0, td->td_ucred, td);
+ if (error) {
+ printf("%s: socreate, error=%d\n", __func__, error);
+ return (error);
+ }
+
/* boot NIC */
strlcpy(ifr.ifr_name, ifp->if_xname, sizeof(ifr.ifr_name));
/* set IFF_UP */
- error = ifioctl(NULL, SIOCGIFFLAGS, (caddr_t)&ifr, td);
+ error = ifioctl(so, SIOCGIFFLAGS, (caddr_t)&ifr, td);
if (error) {
printf("ifioctl SIOCGIFFLAGS\n");
return (error);
}
ifr.ifr_flags |= IFF_UP;
- error = ifioctl(NULL, SIOCSIFFLAGS, (caddr_t)&ifr, td);
+ error = ifioctl(so, SIOCSIFFLAGS, (caddr_t)&ifr, td);
if (error) {
printf("ifioctl SIOCSIFFLAGS\n");
return (error);
}
+ soclose(so);
return (0);
}

Ian Lepore

2018-02-06 18:50:01 UTC

Permalink

Post by John Nielsen

Post by John Nielsen
[ resending from correct email address ]

Post by Maurizio Vairani
I am running
# uname
-a
FreeBSD 12.0-CURRENT FreeBSD 12.0-CURRENT #0 r328383: Thu Jan
25 04:48:52
4.amd64/sys/GENERIC
amd64
https://lists.freebsd.org/pipermail/freebsd-current/2018-Januar
y/068272.html
I can boot FreeBSD via iSCSI using iPXE. But when the isboot, the iSCSI
https://mega.nz/#!tkVwBBKA!PUj14-Za6KCNaoo9hxuXORRLQoWkb4LMvTdU
A1BorD4
Any idea?

Bummer!
Aoyama-san-
Are you still maintaining isboot? Can you help debug this issue
on FreeBSD 12-CURRENT?
Once we get it working I will update the port with whatever is
needed and send you the patches in case you'd like to cut a new
release.
Thank you!
I have solved the issue changing the function isboot_ifup() in
the source file isboot.c.

Apparently sending a NULL socket pointer to ifioctl hasn't worked
https://svnweb.freebsd.org/base?view=revision&revision=218757
So I'm going to add this patch to the port unconditionally once it works.
Unfortunately, I can't compile the port with either my patch below or
your original replacement version of isboot_ifup(). :( Did you make
--- isboot.o ---
isboot.c:425:53: error: incomplete definition of type 'struct thread'
    error = socreate(AF_INET, &so, SOCK_DGRAM, 0, td->td_ucred, td);
                                                  ~~^
/usr/src/sys/sys/systm.h:185:8: note: forward declaration of 'struct thread'
struct thread;
       ^
1 error generated.

Try adding #include <sys/proc.h> if it's not already in the list. It
may be that that file got included via pollution from some other header
file in the past and maybe now that has changed.

If you're already including sys/proc.h then I'm clueless.

-- Ian

John Nielsen

2018-02-06 22:02:10 UTC

Permalink

Post by John Nielsen
Apparently sending a NULL socket pointer to ifioctl hasn't worked
https://svnweb.freebsd.org/base?view=revision&revision=218757
So I'm going to add this patch to the port unconditionally once it works.
Unfortunately, I can't compile the port with either my patch below or
your original replacement version of isboot_ifup(). :( Did you make
--- isboot.o ---
isboot.c:425:53: error: incomplete definition of type 'struct thread'
error = socreate(AF_INET, &so, SOCK_DGRAM, 0, td->td_ucred, td);
~~^
/usr/src/sys/sys/systm.h:185:8: note: forward declaration of 'struct thread'
struct thread;
^
1 error generated.

Try adding #include <sys/proc.h> if it's not already in the list. It
may be that that file got included via pollution from some other header
file in the past and maybe now that has changed.
If you're already including sys/proc.h then I'm clueless.

Maurizio Vairani

2018-02-07 13:07:34 UTC

Permalink

Post by John Nielsen

Try adding #include <sys/proc.h> if it's not already in the list. It
may be that that file got included via pollution from some other header
file in the past and maybe now that has changed.
If you're already including sys/proc.h then I'm clueless.

I am running:
# uname -a
FreeBSD 12.0-CURRENT FreeBSD 12.0-CURRENT #0 r328383: Thu Jan 25 04:48:52
UTC 2018 ***@releng3.nyi.freebsd.org:/usr/obj/usr/src/amd64.amd64/sys/GENERIC
amd64

after upgrading the ports tree with:
# portsnap fetch update

I have copied the directory /usr/ports/net/isboot-kmod/ in
/root/src/isboot-kmod and /root/src/isboot-kmod.orig
# ls -l /root/src
total 6
drwxr-xr-x 3 root wheel 6 Feb 7 13:46 isboot-kmod
drwxr-xr-x 3 root wheel 6 Feb 7 13:46 isboot-kmod.orig
-rw-rw-rw- 1 root wheel 5630 Feb 7 11:38 isboot_patch.txt

Trying to apply the patch I obtain the error:
# cd /root/src
# patch -sC < isboot_patch.txt
2 out of 2 hunks failed while patching isboot-kmod/Makefile
5 out of 5 hunks failed while patching isboot-kmod/files/patch-isboot.c

What I am missing ?
Thanks again for your work.
--
Maurizio

John Nielsen

2018-02-07 18:29:53 UTC

Permalink

Post by John Nielsen

Try adding #include <sys/proc.h> if it's not already in the list. It
may be that that file got included via pollution from some other header
file in the past and maybe now that has changed.
If you're already including sys/proc.h then I'm clueless.

Thanks Ian, that appears to work.
Maurizio, can you apply the attached patch to a clean ports tree and see if isboot-kmod will build and function properly for you? This is all the changes from this thread and the previous one. If you let me know it works I'll get the port updated.
Hi John, I need some help.
# uname -a
# portsnap fetch update
I have copied the directory /usr/ports/net/isboot-kmod/ in /root/src/isboot-kmod and /root/src/isboot-kmod.orig
# ls -l /root/src
total 6
drwxr-xr-x 3 root wheel 6 Feb 7 13:46 isboot-kmod
drwxr-xr-x 3 root wheel 6 Feb 7 13:46 isboot-kmod.orig
-rw-rw-rw- 1 root wheel 5630 Feb 7 11:38 isboot_patch.txt
# cd /root/src
# patch -sC < isboot_patch.txt
2 out of 2 hunks failed while patching isboot-kmod/Makefile
5 out of 5 hunks failed while patching isboot-kmod/files/patch-isboot.c
What I am missing ?
Thanks again for your work.

Not sure but I ran in to similar issues testing here as well. Here's the "svn diff" patch which does work for me. Note that this one should be applied from within the isboot-kmod directory.

Maurizio Vairani

2018-02-08 12:32:18 UTC

Permalink

Post by John Nielsen

Try adding #include <sys/proc.h> if it's not already in the list. It
may be that that file got included via pollution from some other header
file in the past and maybe now that has changed.
If you're already including sys/proc.h then I'm clueless.

Thanks Ian, that appears to work.
Maurizio, can you apply the attached patch to a clean ports tree and see

if isboot-kmod will build and function properly for you? This is all the
changes from this thread and the previous one. If you let me know it works
I'll get the port updated.

Post by John Nielsen
Hi John, I need some help.
# uname -a
FreeBSD 12.0-CURRENT FreeBSD 12.0-CURRENT #0 r328383: Thu Jan 25

usr/obj/usr/src/amd64.amd64/sys/GENERIC amd64

Post by John Nielsen
# portsnap fetch update
I have copied the directory /usr/ports/net/isboot-kmod/ in

/root/src/isboot-kmod and /root/src/isboot-kmod.orig

Post by John Nielsen
# ls -l /root/src
total 6
drwxr-xr-x 3 root wheel 6 Feb 7 13:46 isboot-kmod
drwxr-xr-x 3 root wheel 6 Feb 7 13:46 isboot-kmod.orig
-rw-rw-rw- 1 root wheel 5630 Feb 7 11:38 isboot_patch.txt
# cd /root/src
# patch -sC < isboot_patch.txt
2 out of 2 hunks failed while patching isboot-kmod/Makefile
5 out of 5 hunks failed while patching isboot-kmod/files/patch-isboot.c
What I am missing ?
Thanks again for your work.

Not sure but I ran in to similar issues testing here as well. Here's the
"svn diff" patch which does work for me. Note that this one should be
applied from within the isboot-kmod directory.

With this patch I receive this error :
# pwd
/root/src/isboot-kmod
# patch -sC < ../isboot-kmod-0.2.13_2.diff.txt
2 out of 2 hunks failed while patching Makefile
5 out of 5 hunks failed while patching files/patch-isboot.c