I'm in the middle of moving to a new apartment right now. It's going to
be a bit before I can get to this.
Post by Warner LoshOK. I've pushed in the main part of it. The additional work I have
shouldn't affect any of this stuff. I was going to look at what part(s)
of your open reviewed needed to be redone tomorrow and send you
feedback, but if you wanted to get a start before then, I'm happy to
answer questions. All the rest of my work is going to be selecting the
root partition when we're told to us a specific partition, so will be
very constrained.
Warner
I think the thing to do at this point is to wait for the current work on
loader.efi to land, then adapt my patches to apply against that work.
Post by Warner LoshStill reviewing the code. I'm worried it's too i386 specific and it
conflicts with some work I'm doing. I'll have a list of actionable
critiques this week.
Warner
On Wed, Apr 11, 2018 at 1:03 PM, Oliver Pinter
   Hi!
   Is there any update regarding the rebase or the inclusion to base
   system?
   > I'll do another rebase from head just to be sure
   >
   >>It's on my list for nexr, finally. I have an alternate patch for
   >>loader.efi
   >>from ESP, but i don't think it will affect the GELI stuff. I have some
   >>time
   >>slotted for integration issues though.
   >>
   >>I am quite mindful of the freeze dates.... I have some uefi boot
   >>loader
   >>protocol changes that I need to get in.
   >>
   >>Warner
   >>
   >>
   >>> Awesome, thanks for the update and the work that you have done!
   >>>
   >>> Now we just need some more reviewers eyes on the code :)
   >>>
   >>> Br,
   >>>
   >>> Tommi
   >>>
   >>>
   >>>> FYI, I just IFC'ed everything, and the current patches
are still
Post by Warner Losh   >>fine.
   >>>>
   >>>> Also, the full GELI + standalone loader has been deployed
on one of
Post by Warner Losh   >>my
   >>>> laptops for some time now.
   >>>>
   >>>> > The GELI work could be merged at this point, though it
won't be
Post by Warner Losh   >>usable
   >>>> > without an additional patch to enable loader-only
operation. The
Post by Warner Losh   >>>> >
   >>>> >
   >>>> >
   >>>> > https://reviews.freebsd.org/D12732
<https://reviews.freebsd.org/D12732>
Post by Warner Losh   <https://reviews.freebsd.org/D12732
<https://reviews.freebsd.org/D12732>>
Post by Warner Losh   >>>> >
   >>>> > This one changes the efipart device. Toomas Soome
identified
Post by Warner Losh   some
   >>>> > problems, which I have addressed. He has not
re-reviewed it,
Post by Warner Losh   >>however.
   >>>> >
   >>>> >
   >>>> > https://reviews.freebsd.org/D12692
<https://reviews.freebsd.org/D12692>
Post by Warner Losh   <https://reviews.freebsd.org/D12692
<https://reviews.freebsd.org/D12692>>
Post by Warner Losh   >>>> >
   >>>> > This adds some crypto code needed for GELI. It simply
adds new
Post by Warner Losh   >>code,
   >>>> > and doesn't conflict with anything.
   >>>> >
   >>>> >
   >>>> > https://reviews.freebsd.org/D12698
<https://reviews.freebsd.org/D12698>
Post by Warner Losh   <https://reviews.freebsd.org/D12698
<https://reviews.freebsd.org/D12698>>
Post by Warner Losh   >>>> >
   >>>> > This adds the EFI KMS interface code, and has the EFI
loader pass
Post by Warner Losh   >>keys
   >>>> > into the keybuf interface.
   >>>> >
   >>>> >
   >>>> > I can't post the main GELI driver until those get
merged, as it
Post by Warner Losh   >>depends
   >>>> > on them. It can be found on the geli branch on my
github freebsd
Post by Warner Losh   >>>> > repository, however.
   >>>> >
   >>>> >
   >>>> > Additionally, you need this patch, which allows
loader.efi to
Post by Warner Losh   >>function
   >>>> >
   >>>> > https://reviews.freebsd.org/D13497
<https://reviews.freebsd.org/D13497>
Post by Warner Losh   <https://reviews.freebsd.org/D13497
<https://reviews.freebsd.org/D13497>>
Post by Warner Losh   >>>> >
   >>>> >> Hi Eric,
   >>>> >>
   >>>> >> could you provide a brief update how the work is going?
   >>>> >>
   >>>> >>
   >>>> >> Br,
   >>>> >>
   >>>> >> Tommi
   >>>> >>
   >>>> >>
   >>>> >> On Nov 16, 2017 04:29, "Eric McCorkle"
   >>>> >>
   >>>> >>   Right, so basically, the remaining GELI patches
are against
Post by Warner Losh   >>>> loader, and
   >>>> >>   most of them can go in independently of the work
on removing
Post by Warner Losh   >>boot1.
   >>>> >>   There's a unanimous consensus on getting rid of
boot1 which
Post by Warner Losh   >>>> includes its
   >>>> >>   original author, so that's going to happen.
   >>>> >>
   >>>> >>
   >>>> >>   For GELI, we have the following (not necessarily
   >>>> >>
   >>>> >>   a) Adding the KMS interfaces, pseudo-device, and
kernel
Post by Warner Losh   >>keybuf
   >>>> >>   interactions
   >>>> >>   b) Modifications to the efipart driver
   >>>> >>   c) boot crypto
   >>>> >>   d) GELI partition types (not strictly necessary)
   >>>> >>
   >>>> >>   Then there's the GELI driver itself. (a) and (c) are
   good to
   >>>> land, (b)
   >>>> >>   needs some more work after Toomas Soome pointed out a
   >>legitimate
   >>>> >>   problem, and (d) actually needs a good bit more
code (but
Post by Warner Losh   >>again,
   >>>> it's
   >>>> >>   more cosmetic). Additionally, the GELI driver
will need
Post by Warner Losh   >>further
   >>>> mods to
   >>>> >>   efipart to be written (nothing too big). But we
could go
Post by Warner Losh   >>ahead
   >>>> with (a)
   >>>> >>   and (c), as they've already been proven to work.
   >>>> >>
   >>>> >>   I'd wanted to have this stuff shaped up sooner,
but I'm
Post by Warner Losh   >>>> preoccupied with
   >>>> >>   the 7th RISC-V workshop at the end of the month.
   >>>> >>
   >>>> >>   Once this stuff is all in, loader should handle
any GELI
Post by Warner Losh   >>volumes it
   >>>> >>   finds, and it should Just Work once boot1 is gone.
   >>>> >>
   >>>> >>
   >>>> > _______________________________________________
   >>>> > https://lists.freebsd.org/mailman/listinfo/freebsd-current
<https://lists.freebsd.org/mailman/listinfo/freebsd-current>
Post by Warner Losh   <https://lists.freebsd.org/mailman/listinfo/freebsd-current
<https://lists.freebsd.org/mailman/listinfo/freebsd-current>>
Post by Warner Losh   >>>> freebsd.org <http://freebsd.org> <http://freebsd.org>"
   >>>> >
   >>>>
   >>>
   >
   > --
   > Sent from my Android device with K-9 Mail. Please excuse my brevity.
   > _______________________________________________
   mailing list
   > https://lists.freebsd.org/mailman/listinfo/freebsd-current
<https://lists.freebsd.org/mailman/listinfo/freebsd-current>
Post by Warner Losh   <https://lists.freebsd.org/mailman/listinfo/freebsd-current
<https://lists.freebsd.org/mailman/listinfo/freebsd-current>>
Post by Warner Losh   > To unsubscribe, send any mail to
   >