Discussion:
head -r335568 breaks the ci.freebsd.org builds of the various
(too old to reply)
Mark Millard
2018-06-22 23:03:06 UTC
Permalink
from the likes of:

https://ci.freebsd.org/job/FreeBSD-head-sparc64-build/8346/consoleText

--- nfs_commonkrpc.o ---
/usr/src/sys/fs/nfs/nfs_commonkrpc.c: In function 'newnfs_request':
/usr/src/sys/fs/nfs/nfs_commonkrpc.c:813: error: 'ND_HASSLOTID' undeclared (first use in this function)
/usr/src/sys/fs/nfs/nfs_commonkrpc.c:813: error: (Each undeclared identifier is reported only once
/usr/src/sys/fs/nfs/nfs_commonkrpc.c:813: error: for each function it appears in.)
*** [nfs_commonkrpc.o] Error code 1

(a gcc 4.2.1 context).

Similarly for clang-based:

--- all_subdir_nfscommon ---
/usr/src/sys/fs/nfs/nfs_commonkrpc.c:814:20: error: use of undeclared identifier 'ND_HASSLOTID'
(ND_NFSV41 | ND_HASSLOTID) && nmp != NULL &&


===
Mark Millard
marklmi at yahoo.com
( dsl-only.net went
away in early 2018-Mar)
Rick Macklem
2018-06-23 00:52:56 UTC
Permalink
Post by Mark Millard
https://ci.freebsd.org/job/FreeBSD-head-sparc64-build/8346/consoleText
--- nfs_commonkrpc.o ---
/usr/src/sys/fs/nfs/nfs_commonkrpc.c:813: error: 'ND_HASSLOTID' undeclared (first >use in this function)
/usr/src/sys/fs/nfs/nfs_commonkrpc.c:813: error: (Each undeclared identifier is >reported only once
/usr/src/sys/fs/nfs/nfs_commonkrpc.c:813: error: for each function it appears in.)
*** [nfs_commonkrpc.o] Error code 1
As you might have guessed, I missed part of the commit.
Should be fixed by r335571.

Pointy hat goes on me.

Thanks for reporting it, rick

Loading...